Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Default impl for Font #174

Closed
17cupsofcoffee opened this issue May 2, 2020 · 3 comments
Closed

Remove Default impl for Font #174

17cupsofcoffee opened this issue May 2, 2020 · 3 comments
Labels
API: Breaking Indicates that resolving the issue would be a breaking change. Area: Graphics Issues related to graphics/rendering. Type: Bug Problems with the code/documentation that need to be fixed.
Milestone
0.4.0

Comments

@17cupsofcoffee
Copy link
Owner

Summary:
We currently bundle Deja Vu Sans Mono as the default font in Tetra, but there's a couple of issues with this:

  • It's not immediately obvious that you have to include the font's license when distributing your game.
  • The font's bytes are included in the binary even if you never actually use them, which seems a bit dodgy licensing-wise.

I think the best solution would be to just not bundle fonts with Tetra - it'll keep the binary size lower for games that don't use TTF rendering, and it immediately solves all these murky licensing questions.

I'll publish a version of Tetra soon deprecating the Default impl, and remove it entirely in 0.4.0 (probably alongside the new TTF renderer being added).
@17cupsofcoffee 17cupsofcoffee added Type: Bug Problems with the code/documentation that need to be fixed. Area: Graphics Issues related to graphics/rendering. API: Breaking Indicates that resolving the issue would be a breaking change. labels May 2, 2020
@17cupsofcoffee
Copy link
Owner Author

Doh, you can't deprecate trait impls.

@17cupsofcoffee
Copy link
Owner Author

Done on the 0.4 branch.

@17cupsofcoffee 17cupsofcoffee added this to the 0.4.0 milestone Jun 8, 2020
@17cupsofcoffee
Copy link
Owner Author

Released in 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: Breaking Indicates that resolving the issue would be a breaking change. Area: Graphics Issues related to graphics/rendering. Type: Bug Problems with the code/documentation that need to be fixed.
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@17cupsofcoffee