Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup_PeerReview #2

Open
AnaHowellsFerreira opened this issue Oct 26, 2018 · 0 comments
Open

Dedup_PeerReview #2

AnaHowellsFerreira opened this issue Oct 26, 2018 · 0 comments

Comments

@AnaHowellsFerreira
Copy link

Hi Max!

I gotta say, I am a big fan of your coding style and I have already learned
so much from you since we joined the program.

Thank you for including all the comments (I’m sure they are mostly for yourself, but it helps me too) and for sharing your rationale on why you are doing stuff a certain way. I basically had very similar strategies, but you were able to articulate your ideas so much better. I am guessing you are building line
by line and printing them, correct? I was just wondering if you use print statements to debug your code as you build it which is something I got to use a lot more on the previous assignment. I think the only thing missing is the argparse (which might be required for this one; just double check). Otherwise, everything looks great, so, yes, algorithm makes sense to me and I can follow the logic; no stand alone pieces of code and functions seem reasonable.

Good luck!
Ana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant