Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clang-tidy in linalg wrappers #414

Open
5 tasks
knarfnitram opened this issue Feb 21, 2025 · 0 comments
Open
5 tasks

Enable clang-tidy in linalg wrappers #414

knarfnitram opened this issue Feb 21, 2025 · 0 comments
Labels
priority: low Issues with low priority type: clean code Clean coding and good programming practices type: enhancement A new feature or enhancement to be implemented

Comments

@knarfnitram
Copy link
Contributor

Description

As pointed out in #403, we do not apply the style format to the files:

  • 4C_linalg_vector.hpp/cpp
  • 4C_linalg_graph.hpp/cpp

This means that the functions should be renamed within the code base.
Clang-Tidy suggests appropriate function names, which are inline with our style-format. As an example, this will look like:
graph.Comm() -> graph.comm() or
get_ref_of_Epetra_Vector -> get_ref_of_epetra_vector()

Possible Solution and Definition of Done

  • Remove // NOLINTBEGIN(readability-identifier-naming) at the files
  • Run clang-tidy
  • Rename the corresponding functions as suggested by clang-tidy within all appearances

Interested Parties

@amgebauer @mayrmt

@knarfnitram knarfnitram added priority: low Issues with low priority type: clean code Clean coding and good programming practices type: enhancement A new feature or enhancement to be implemented labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Issues with low priority type: clean code Clean coding and good programming practices type: enhancement A new feature or enhancement to be implemented
Projects
None yet
Development

No branches or pull requests

1 participant