Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input] Remove remnants of old input mechanisms and use InputSpec directly #463

Open
7 tasks
sebproell opened this issue Feb 28, 2025 · 3 comments
Open
7 tasks

[Input] Remove remnants of old input mechanisms and use InputSpec directly #463

sebproell opened this issue Feb 28, 2025 · 3 comments
Labels
priority: low Issues with low priority status: ready Issues that are well-prepared with detailed description ready to be processed type: clean code Clean coding and good programming practices

Comments

@sebproell
Copy link
Member

Description

The various ways to read input have all been superseded by InputSpec. However, some old interfaces still exist. Internally, they already call the new functionality. To get a consistent user experience and show that people can actually use the new feature everywhere, we should remove these.

Possible Solution and Definition of Done

  • Remove the helpers in Core::Utils
    • Remove bool_parameter
    • Remove int_parameter
    • Remove double_parameter
    • Remove string_parameter
    • Remove string_to_integral_parameter
    • Remove temporary helper SectionSpecs
@sebproell sebproell added priority: low Issues with low priority status: ready Issues that are well-prepared with detailed description ready to be processed type: clean code Clean coding and good programming practices type: enhancement A new feature or enhancement to be implemented labels Feb 28, 2025
@sebproell
Copy link
Member Author

FYI @maxiludwig

@sebproell sebproell removed the type: enhancement A new feature or enhancement to be implemented label Feb 28, 2025
@lauraengelhardt
Copy link
Contributor

I just started removing int_parameter; seems to be doable with a regex search and replace quite well.

@sebproell
Copy link
Member Author

@lauraengelhardt Thanks! Please coordinate with @maxiludwig who also removes some helpers.

@maxiludwig maxiludwig mentioned this issue Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Issues with low priority status: ready Issues that are well-prepared with detailed description ready to be processed type: clean code Clean coding and good programming practices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebproell @lauraengelhardt