Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining hard-coded reference to "aws-vault" #38

Closed
solvingj opened this issue Mar 11, 2019 · 0 comments · Fixed by #41
Closed

Remove remaining hard-coded reference to "aws-vault" #38

solvingj opened this issue Mar 11, 2019 · 0 comments · Fixed by #41

Comments

@solvingj
Copy link

solvingj commented Mar 11, 2019

https://github.com/99designs/keyring/blob/master/wincred.go#L78

It looks like this is a remnant of the time before this library was a separate project from aws-vault application.

Of note, based on cursory testing, it seems that the result of this is that windows credentials will always show up under aws-vault: service name. When I set ServiceName variable on the configuration myself to xyz, the credential appears in Windows Credential manager as aws-vault:xyz:<my-key>. I am new to the project, but it looks like simply removing "aws-vault:" + from this line would resolve the issue.

Also, I checked to see if this would break aws-vault project, and I don't think it will. I actually think it fixes a cosmetic bug there, but I don't use aws-vault so I can't be sure. Based on this line and my own test, I believe that currently, aws-vault creds are probably showing up in Windows Credential Manager as aws-vault:aws-vault:<some_cred>

https://github.com/99designs/aws-vault/blob/master/cli/global.go#L83

Perhaps this will be trivial to prove and fix for someone on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant