Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement react_T_min/max and react_rho_min/max for SDC #598

Closed
zingale opened this issue Apr 11, 2019 · 4 comments
Closed

implement react_T_min/max and react_rho_min/max for SDC #598

zingale opened this issue Apr 11, 2019 · 4 comments
Labels
sdc

Comments

@zingale
Copy link
Member

zingale commented Apr 11, 2019

If we are outside of these bounds, we can skip the nonlinear SDC solve and just do the advective update.
@zingale zingale added the sdc label Apr 11, 2019
@zingale
Copy link
Member Author

zingale commented Jul 14, 2019 •
edited
Loading

the main difficulty here is that for the 4th order, we go into the reaction solve with a cell-centered "C", so we need a way to just bail out and do the update with the reactions set to 0. It might be fine to just set R = 0, since we redo the conservative update. There will still be the cost of the <C> -> C transformation, but we'll skip the whole nonlinear solve.

@zingale
Copy link
Member Author

zingale commented Aug 19, 2019 •
edited
Loading

to be consistent, we also need to do this in construct_old_react_source

this is not needed, since it is just a call to ca_instantaneous_react

@zingale
Copy link
Member Author

zingale commented Aug 19, 2019

we also need this logic in ca_instantaneous_react

@zingale
Copy link
Member Author

zingale commented Aug 19, 2019

maybe it would be useful to have a function okay_to_burn(U) that returns true if we should do reactions and false otherwise. This way we don't need to replicate this logic all over the place.

zingale added a commit that referenced this issue Aug 19, 2019
@zingale
first pass at implementing limits on burning for SDC
e578f06 
addresses #598
@zingale zingale mentioned this issue Aug 19, 2019
Merged
5 tasks
zingale added a commit that referenced this issue Sep 23, 2019
@zingale
some SDC improvements (#654)
82f51a3 
Implements reflecting BCs for PLM reconstruction with SDC (issue #652)

Implements the density and temperature limits to burning for SDC (issue #598)

Fixes the weighting of the flux registers for SDC (#658)

Implements a well-balanced scheme for 2nd order PLM reconstruction (#294)

Also adapts the bubble_convergence problem to work as a test for the well-balanced method and can now do second-order or fourth order initial model generation.

Changes the meaning of the plm_iorder flag to now do 1 = piecewise constant, 2 = 2nd order MC limiter, and >= 3 for 4th order MC limiter

Adds support for HSE boundary conditions in +X and +Y
@zingale zingale closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale