Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Strang + MOL (time_integration_method = 1) #638

Closed
zingale opened this issue Jul 13, 2019 · 0 comments
Closed

remove Strang + MOL (time_integration_method = 1) #638

zingale opened this issue Jul 13, 2019 · 0 comments

Comments

@zingale
Copy link
Member

zingale commented Jul 13, 2019

The new SDC method is merged and does proper coupling of hydro and reactions, making the Strang + MOL method not necessary. If we want to do Strang, then CTU is better. If we want to do a MOL-style integration, then the SDC integration, even 2nd order in time, should be better than the MOL. Furthermore, the SDC method extends more easily to AMR + subcycling.

I propose we remove the pure MOL (RK time integration) method, since we are not likely to use it and don't want to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant