Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Microphysics's Make.Microphysics #772

Closed
zingale opened this issue Feb 15, 2020 · 3 comments
Closed

use Microphysics's Make.Microphysics #772

zingale opened this issue Feb 15, 2020 · 3 comments
Assignees
@zingale

Comments

@zingale
Copy link
Member

zingale commented Feb 15, 2020

Instead of reproducing all of the make stuff in Make.Castro, we should include the Make.Microphysics provided by Microphysics. This is now possible because we require Microphysics to build.
@zingale zingale self-assigned this Feb 15, 2020
@zingale
Copy link
Member Author

zingale commented Feb 16, 2020

we'd actually need to split it up a bit, since Make.Microphysics does

include $(AMREX_HOME)/Tools/GNUMake/Make.defs

which we do in Make.Castro.

@maximumcats
Copy link
Member

maximumcats commented Feb 16, 2020 •
edited
Loading

Another way to approach it is to modularize the individual components of Microphysics such that Make.Microphysics conceptually looks as close as possible to

include Networks/Make.networks
include EOS/Make.EOS
include rates/Make.rates
...

in which case we'd have minimal redundancy by doing the same thing in Make.Castro.

@zingale
Copy link
Member Author

zingale commented Feb 25, 2020

this was done in #782

@zingale zingale closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zingale zingale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zingale @maximumcats