Updating up A4 model parameters #3031
Merged
+16,733
−20,678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisclark91
changed the title
aisclark91
changed the title
aisclark91
changed the title
zingale
reviewed
Feb 26, 2025
zingale
reviewed
Feb 26, 2025
zingale
reviewed
Feb 26, 2025
zingale
reviewed
Feb 26, 2025
zingale
reviewed
Feb 26, 2025
zingale
reviewed
Feb 27, 2025
|
|
||
|
|
||
| #if AMREX_SPACEDIM == 3 | ||
| amr.max_grid_size = 64 | ||
| amr.blocking_factor = 32 |
There was a problem hiding this comment.
I was using max_grid_size = 96 and blocking_factor=16 on Frontier. We should play around with these more.
zingale
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this PR I update the necessary parameters to run the A4 model.