store the Reactions_Type stuff a proper cell-averages to 4th order #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the plotfiles
|
I can confirm that with this change, enuc and omegadot_X converge 4th order. |
|
test suite changes are as expected (only enuc and the omegadot terms change for the SDC problems). This is ready for review |
harpolea
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This changes the way we fill Reactions_Type (which is used for the reaction quantities in the plotfile). We now properly compute the average to 4th order for
sdc_order == 4. Closes #577PR checklist
CHANGESfile has been updated