remove the RK-based MOL time integration method #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is not tested, still uses Strang, and doesn't have an easy path to AMR SDC is the better option.
harpolea
reviewed
Aug 30, 2019
Source/driver/Castro.cpp
Outdated
| if (do_radiation && time_integration_method != CornerTransportUpwind) { | ||
| amrex::Error("Radiation is currently unsupported for MOL when using CUDA."); | ||
| amrex::Error("Radiation is currently unsupported for CTU time advancement."); |
There was a problem hiding this comment.
I think this should say Radiation is currently only supported for CTU time advancement?
maximumcats
reviewed
Sep 8, 2019
Source/driver/Castro_setup.cpp
Outdated
| //node_weights.resize(SDC_NODES); | ||
| //node_weights = {1.0/6.0, 4.0/6.0, 1.0/6.0}; | ||
|
|
||
| } else if (sdc_order == 20) { |
There was a problem hiding this comment.
Can we remove this Radau code from this PR please, and defer it to #666?
maximumcats
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
it is not tested, still uses Strang, and doesn't have an easy path to AMR
SDC is the better option.
addresses #638
PR checklist
CHANGESfile has been updated