Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce memory usage for conserved-state sources #699

Merged
merged 8 commits into from
Nov 29, 2019
Merged

reduce memory usage for conserved-state sources #699

merged 8 commits into from
Nov 29, 2019

Conversation

zingale
Copy link
Member

@zingale zingale commented Nov 26, 2019

PR summary

This change removes the species from the conserved state sources. Closes #698

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite
  • all functions have docstrings as per the coding conventions
  • the CHANGES file has been updated
  • if appropriate, this change is described in the docs

@zingale zingale marked this pull request as ready for review November 26, 2019 20:59
@zingale
Copy link
Member Author

zingale commented Nov 26, 2019

all CPU tests pass

@zingale
Copy link
Member Author

zingale commented Nov 26, 2019

GPU tests pass

@zingale zingale merged commit 799174f into development Nov 29, 2019
@zingale zingale deleted the conserved_sources branch November 29, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximumcats maximumcats maximumcats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maximumcats