Add an option for implicit external source terms #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingale
approved these changes
Dec 13, 2019
|
all tests pass, but the PR suggested that answers should change, so I will not merge until we understand this. |
|
I incorrectly believed that at least one of the wdmerger problems was using the external source terms, but this was not the case. I have now made this change on wdmerger_3D in development. Please run that test on development, reset it, and then re-run the test on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The external source terms are currently only implemented as an explicit predictor-corrector scheme. This is incompatible with how wdmerger implements its relaxation source term, so wdmerger is currently not working as intended. This PR introduces a new option, castro.ext_src_implicit (defaulting to 0) which, if turned on, changes the handling of the external source terms to allow an implicit solve. This is done by subtracting the full old-time source and adding the full new-time source in the corrector, rather than -0.5 and +0.5 of each, respectively. It would still be up to the individual problem to make sure they are consistent with this scheme if they turn the option on. Even if they don't, the source term ends up being a simple time-advanced source term at n+1 which is not a serious problem.
PR checklist
CHANGESfile has been updated