Add a flux limiter based on large velocities #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingale
approved these changes
Dec 19, 2019
5 tasks
zingale
pushed a commit
that referenced
this pull request
Apr 24, 2022
This was added in #712 but ended up not being that useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This new flux limiter uses the same algorithm as the existing flux limiter that prevents small densities, but uses it to prevent large velocities (specifically, larger than riemann_speed_limit). This is useful for situations where large speeds are being generated in low-density material due to a large momentum flux from an adjacent high density zone.
PR checklist
CHANGESfile has been updated