Set compute_new_dt_on_regrid by default #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The AMR parameter
amr.compute_new_dt_on_regrid
is now on by default; closes #356. This avoids crashes that result from the CFL number being too large after regridding, because we update the timestep after seeing that larger velocity.The user can still opt to set this off if they want to, since the location where we're setting it in Castro occurs before the Amr ParmParse of this parameter.
PR checklist
CHANGES
file has been updated