convert some CTU hydro routines to C++ #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all CPU tests pass |
|
GPU works for everything except wdmerger. This is a hybrid hydro issue. We get: |
|
The issue is the call to |
|
GPU tests now pass: CPU tests pass too (note: the failures are because of changes on development not merged into this): this is ready to be merged |
maximumcats
reviewed
Feb 12, 2020
maximumcats
reviewed
Feb 12, 2020
Source/hydro/Castro_ctu_hydro.cpp
Outdated
| { | ||
| flatn_arr(i,j,k) = flatn_arr(i,j,k) * flatg_arr(i,j,k); | ||
|
|
||
| if (Radiation::flatten_pp_threshold > 0.0) { |
There was a problem hiding this comment.
We cannot directly read class member variables in the lambdas on the device. For now we'll need to make a local copy of this variable outside the parallel for.
maximumcats
reviewed
Feb 12, 2020
Source/hydro/Castro_ctu_hydro.cpp
Outdated
| if ( q_arr(i-1,j,k,QU) + q_arr(i,j-1,k,QV) + q_arr(i,j,k-1,QW) > | ||
| q_arr(i+1,j,k,QU) + q_arr(i,j+1,k,QV) + q_arr(i,j,k+1,QW) ) { | ||
|
|
||
| if (q_arr(i,j,k,QPRES) < Radiation::flatten_pp_threshold * q_arr(i,j,k,QPTOT)) { |
There was a problem hiding this comment.
Same comment for this one :-)
maximumcats
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This converts the CTU consup for hydro (not radiation) , the flattening routines, and src_to_prim to C++
PR checklist
CHANGESfile has been updated