2nd order MOL/SDC cleaning #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests now pass (there are 3 in the test suite that do 2nd order SDC) |
maximumcats
reviewed
Jan 28, 2020
|
|
||
| // compute the fluxes and add artificial viscosity | ||
| dq.resize(obx, NQ); | ||
| Elixir elix_dq = dq.elixir(); |
There was a problem hiding this comment.
This won't work, but we can resolve that when we do the final pass for GPUs.
There was a problem hiding this comment.
okay, but can you briefly share why it doesn't work?
maximumcats
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This reduced the memory needed for the interface states by doing all of the state reconstruction / flux solve in a loop over dimensions. Addresses #741
PR checklist
CHANGESfile has been updated