Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get the aux_names from the C++ header #784

Merged
merged 1 commit into from
Feb 22, 2020
Merged

get the aux_names from the C++ header #784

merged 1 commit into from
Feb 22, 2020

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 21, 2020

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite
  • all functions have docstrings as per the coding conventions
  • the CHANGES file has been updated
  • if appropriate, this change is described in the docs

@maximumcats
Copy link
Member

Since this depends on recent changes to Microphysics, please include an update to the Microphysics submodule to at least the commit corresponding to AMReX-Astro/Microphysics#258. If we merge #782 first, this will be unnecessary.

@zingale
Copy link
Member Author

zingale commented Feb 21, 2020

already merged #782 with a submodule update, so I think we're good.

@zingale zingale merged commit 72a3545 into development Feb 22, 2020
@zingale zingale deleted the aux_names branch February 22, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximumcats maximumcats maximumcats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maximumcats