Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid the possibility of HLL flux being undefined #823

Merged
merged 1 commit into from
Mar 21, 2020
Merged

avoid the possibility of HLL flux being undefined #823

merged 1 commit into from
Mar 21, 2020

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 21, 2020

PR summary

This addresses #808

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite
  • all functions have docstrings as per the coding conventions
  • the CHANGES file has been updated
  • if appropriate, this change is described in the docs

@zingale
have the HLL solver modify the flux passed in
a8df299 
this fixes a bug where we may have an uninitialized flux
@zingale zingale changed the title avbid the possibility of HLL flux being undefined avoid the possibility of HLL flux being undefined Mar 21, 2020
@zingale zingale merged commit afd7ecc into development Mar 21, 2020
@zingale zingale deleted the hll_fix branch March 21, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximumcats maximumcats maximumcats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maximumcats