-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"mbed export -m K64F -i eclipse_gcc_arm" fails on mbed-os 5.2 #3190
Comments
Thanks for reporting, I could reproduce the problem |
This lines are to blame https://github.com/ARMmbed/mbed-os/blame/master/tools/export/makefile/__init__.py (for loop and else):
No template found , thus it goes to else. @theotherjimmy should be able to comment what's the intention with that for loop, because the template can't be found after adding NAME to the EclipseXXX classes. @sarahmarshy Note: we really need exporters tests to catch errors like this (its in progress as I have seen or we just failed to run it ?) |
Wonder how difficult it would be to have a CI check for something like this?-) |
@theotherjimmy has an open PR for this. On mobile or I'd find it. |
@sarahmarshy I am going through the PR just now, thanks for the pointer - #3187 |
This will be fixed for 5.2.2 |
CI checks are in the works, keep an eye out 😄 |
@TeroJaasko #3187 is now merged, did this resolve your issue? |
Alright, I'm going to close this now. If it's still a problem, please re-open this issue. |
Yes, the export works now. Thanks. |
Note: This is just a template, so feel free to use/remove the unnecessary things
Description
Bug
Target
K64F
Toolchain:
GCC_ARM
Toolchain version:
mbed-cli version:
0.9.10
meed-os sha:
e2617cc (HEAD, tag: mbed_lib_rev128, tag: mbed-os-5.2.1, tag: latest, origin/mbed-os-5.2)
DAPLink version:
Expected behavior
"mbed export -m K64F -i eclipse_gcc_arm" command produces functional project file just as it did previously.
Actual behavior
Export fails completely.
Steps to reproduce
Enhancement
Git bisect reveals that the commit 2912522 has broken the export. "git revert 2912522" on mbed-os fixes the problem and the project file can be produced again.
Reason to enhance or problem with existing solution
Suggested enhancement
Fix and/or add CI job to detect regressions.
Pros
Cons
Question
How to?
The text was updated successfully, but these errors were encountered: