Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NucleoF446ze CAN Configuration bug #4763

Closed
mr63 opened this issue Jul 17, 2017 · 4 comments
Closed

NucleoF446ze CAN Configuration bug #4763

mr63 opened this issue Jul 17, 2017 · 4 comments

Comments

@mr63
Copy link

mr63 commented Jul 17, 2017

Note: This is just a template, so feel free to use/remove the unnecessary things

Description

  • Type: Bug
  • Priority: Blocker

Bug

Target
NucleoF446ze

Toolchain:
ARM

mbed-cli version:
146:22da

Expected behavior
Set variation of CAN for sync.

Actual behavior
When value is set it is Masked out because of wrong bit mask and has no effect. Leaving the variation to 0.
Steps to reproduce

Testing from one internal channel to another has no effect as they both use the same internal clk source and are always in sync. You must connected to external CAN source and will see that most packets are not excepted.

The problem is found in the can_api.c File line 184
inside of the can_speed function.

when psjw is set it is masked out with the wrong mask value the mask value should be set to:
0x03000000.

Thank You,
Mark


Question

How to?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 17, 2017

@jeromecoutant
Copy link
Collaborator

Hi
Please, be free to send a pull request.
Thx

@bcostm
Copy link
Contributor

bcostm commented Jul 24, 2017

Thanks for reporting this issue.

Fixed in PR #4801

@bcostm
Copy link
Contributor

bcostm commented Aug 16, 2017

Can you please close this issue ? The PR has been merged. Thanks.

ST_TO_BE_CLOSED

@0xc0170 0xc0170 closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants