Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Thread opening by clicking on the watcher notification is inconsistent #371

Closed
K1rakishou opened this issue Oct 3, 2019 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@K1rakishou
Copy link

K1rakishou commented Oct 3, 2019

Sometimes it opens the catalog sometimes it opens one of the pinned threads. This thing should be thought out. But it's not clear what thread exactly should be opened? Lets say you have three pinned threads. When clicking the notification which one of them should we open? Then one with thread lastest post? Or the one where you were mentioned?

@K1rakishou K1rakishou added bug Something isn't working question Further information is requested labels Oct 3, 2019
@K1rakishou K1rakishou changed the title [BUG/IMPROVEMENT] Thread opening by notification clicking is inconsistent [BUG/IMPROVEMENT] Thread opening by clicking on the watcher notification is inconsistent Oct 3, 2019
@K1rakishou
Copy link
Author

K1rakishou commented Oct 3, 2019

So how about the following:

  • If there are replies to your posts - open them first in descending order (the most recent reply will be opened first)
  • If there are no replies to your posts then we open the latest bumped thread.

What do you think?

@Adamantcheese
Copy link
Owner

The current logic is as follows:
If there's one thread with new posts, open that thread.
If there's more than one thread with new posts, open the bookmark sidebar so the user can pick what thread they want to view.

Personally I'm fine with how it's currently implemented, but if we were to assign priority for opening up a thread, it would be quotes first, followed by latest post timestamp, just like how you said. No new posts at all should just open up the bookmark sidebar, so it still has some functionality in that edge case.

@K1rakishou
Copy link
Author

Oh, so that's how it is I didn't even notice that. Yeah, I agree that if there are no new posts at all then we should open the bookmarks list.

@K1rakishou K1rakishou changed the title [BUG/IMPROVEMENT] Thread opening by clicking on the watcher notification is inconsistent [IMPROVEMENT] Thread opening by clicking on the watcher notification is inconsistent Oct 12, 2019
@K1rakishou K1rakishou added enhancement New feature or request and removed bug Something isn't working labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants