Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-68 event types #100

Merged
merged 42 commits into from
Mar 6, 2024
Merged

ENG-68 event types #100

merged 42 commits into from
Mar 6, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Mar 5, 2024

📥 Pull Request

📘 Description
Briefly describe the changes you've made.

🔄 Related Issue (if applicable)
If this PR is related to an existing issue, reference it here.

🎯 Goal
Explain the intention behind this change.

🔍 Additional Context
Any extra information or context to help us understand the change?

🧪 Testing
Describe the tests you performed to validate your changes.

Thank you for your contribution to Agentops!

@HowieG HowieG requested review from siyangqiu and bboynton97 March 5, 2024 02:27
Copy link

gitguardian bot commented Mar 5, 2024

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9706253 Triggered Generic High Entropy Secret 2c85d19 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret c49dd41 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret 5f3f1a9 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret 9aae2aa test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret cf9fd1d test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret e8fcc31 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret b2abab0 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret cb96b22 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret 57a1d81 test_event_ABC.ipynb View secret
9706253 Triggered Generic High Entropy Secret e46355d test_event_ABC.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@HowieG HowieG merged commit a86c066 into main Mar 6, 2024
1 check failed
@siyangqiu siyangqiu deleted the eng-68-event-types branch March 21, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants