Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme error log consent #96

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Readme error log consent #96

merged 5 commits into from
Mar 14, 2024

Conversation

bboynton97
Copy link
Contributor

image

Mostly generated by GPT. The key points are that we adhere to CCPA requirements and that the SDK is subject to our Privacy Policy.

@bboynton97 bboynton97 requested review from siyangqiu and areibman March 1, 2024 21:50
Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise, good to me

Copy link
Contributor

@areibman areibman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a TOS.md instead of putting this in README.md

@bboynton97 bboynton97 requested a review from areibman March 11, 2024 19:05
@areibman
Copy link
Contributor

Let's have a TOS.md instead of putting this in README.md

I looked at some other repos, and TOS is not a common readme (sorry for the misleading suggestion). Let's keep these changes though; I've raised an issue to the documentation repository in the meantime.

Copy link
Contributor

@areibman areibman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Braelyn :)

@bboynton97 bboynton97 merged commit 767863c into main Mar 14, 2024
1 check passed
@siyangqiu siyangqiu deleted the readme-error-log-consent branch March 21, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants