Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suggestIssuer in smart wallet #5914

Closed
samsiegart opened this issue Aug 8, 2022 · 0 comments
Closed

Support suggestIssuer in smart wallet #5914

samsiegart opened this issue Aug 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request UI wallet

Comments

@samsiegart
Copy link
Contributor

samsiegart commented Aug 8, 2022

What is the Problem Being Solved?

For adding liquidity (#5077), the AMM needs to be able to call suggestIssuer on the wallet bridge and have the wallet import the issuer and create a purse for it.

Description of the Design

Implement the suggestInstance method in ScopedBridge.js which shows a request in the user's inbox to import the issuer. It can also have inputs for the issuer petname and purse petname. When the user accepts the request, it can trigger a signed wallet action to call suggestIssuer on the wallet contract.

Security Considerations

The scoped bridge is accessible to the dapps only once the users have approved the dapp, and the issuer will be added to the smart wallet only after the user approves it

Test Plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI wallet
Projects
None yet
Development

No branches or pull requests

1 participant