Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zoe api #43

Merged
merged 8 commits into from
Nov 2, 2019
Merged

Add zoe api #43

merged 8 commits into from
Nov 2, 2019

Conversation

dominiquejane
Copy link
Contributor

@dominiquejane dominiquejane commented Nov 1, 2019 •
edited
Loading

Adds zoe api. 3 sections:

  1. Structs
  2. Zoe
  3. Zoe Governing Contract Facet

Finishes zoe api task in #32

@dominiquejane
Copy link
Contributor Author

@katelynsills Most of zoe is done, just have a few clarifications/concerns that need looking over. One example is missing because I couldn't find a reference to it in the code. Again, they're all marked by red text.

katelynsills
katelynsills reviewed Nov 1, 2019
View reviewed changes
katelynsills
katelynsills reviewed Nov 1, 2019
View reviewed changes
katelynsills
katelynsills reviewed Nov 1, 2019
View reviewed changes
katelynsills
katelynsills reviewed Nov 1, 2019
View reviewed changes
katelynsills
katelynsills approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the Zoe sections, which looked really good to me! Thank you so much! I added some changes. Feel free to merge after those. I'm also updating the zoe.chainmail on ERTP.

dominiquejane
dominiquejane commented Nov 1, 2019
View reviewed changes
Copy link
Contributor Author

@dominiquejane dominiquejane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR according to Kate's comments

@barbaraliau barbaraliau changed the title WIP: Add zoe api Add zoe api Nov 2, 2019
@barbaraliau barbaraliau merged commit 3a61bad into master Nov 2, 2019
@barbaraliau barbaraliau deleted the add-zoe-api branch November 2, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katelynsills katelynsills katelynsills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiquejane @katelynsills @barbaraliau