Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-type Topologic Helper Functions #70

Closed
lukem12345 opened this issue Feb 27, 2024 · 0 comments · Fixed by #87
Closed

Re-type Topologic Helper Functions #70

lukem12345 opened this issue Feb 27, 2024 · 0 comments · Fixed by #87

Comments

@lukem12345
Copy link
Member

          This docstring was confusing: you mean returns a vector where the element at index `i` is a set of simplices of dimension `i - 1`. This should probably be a tuple rather than a vector, and you should wrap it with a struct with a good name, like
struct Simplices{Ts <: Tuple}
  by_dimension::Ts
end

Originally posted by @olynch in #59 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant