Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples do not run #797

Closed
udalrich opened this issue Oct 26, 2016 · 2 comments · Fixed by #829
Closed

Examples do not run #797

udalrich opened this issue Oct 26, 2016 · 2 comments · Fixed by #829

Comments

@udalrich
Copy link

Per the instructions on the home page, I did

$ git clone https://github.com/AllenFang/react-bootstrap-table.git
$ cd react-bootstrap-table
$ npm install
$ gulp example-server #after start, open browser and go to http://localhost:3004

This gave

[11:53:02] Starting 'example-server'...
[11:53:02] Finished 'example-server' after 60 ms
Listening at localhost:3004
webpack: wait until bundle finished: /
Time: 23398ms
        Asset     Size  Chunks       Chunk Names
app.bundle.js  7.35 MB       0       app
   vendors.js   663 kB       1       vendors
chunk    {0} app.bundle.js (app) 3.01 MB {1} [rendered]
chunk    {1} vendors.js (vendors) 224 kB [rendered]

ERROR in ./~/react-router/lib/Router.js
Module not found: Error: Cannot resolve module 'history/lib/createHashHistory' in <path>/react-bootstrap-table/node_modules/react-router/lib
 @ ./~/react-router/lib/Router.js 23:35-75

ERROR in ./~/react-router/lib/useRoutes.js
Module not found: Error: Cannot resolve module 'history/lib/Actions' in <path>/react-bootstrap-table/node_modules/react-router/lib
 @ ./~/react-router/lib/useRoutes.js 15:25-55

ERROR in ./~/react-router/lib/useRoutes.js
Module not found: Error: Cannot resolve module 'history/lib/useQueries' in <path>/react-bootstrap-table/node_modules/react-router/lib
 @ ./~/react-router/lib/useRoutes.js 17:28-61

ERROR in ./~/react-router/lib/match.js
Module not found: Error: Cannot resolve module 'history/lib/createMemoryHistory' in <path>/react-bootstrap-table/node_modules/react-router/lib
 @ ./~/react-router/lib/match.js 13:37-79

ERROR in ./~/react-router/lib/match.js
Module not found: Error: Cannot resolve module 'history/lib/useBasename' in <path>/eact-bootstrap-table/node_modules/react-router/lib
 @ ./~/react-router/lib/match.js 17:29-63
webpack: bundle is now VALID.

When I opened localhost:3004, it showed a blank page.

This is probably related to this message when running npm install:

├── UNMET PEER DEPENDENCY history@^1.17.0

Using Safari 10.0 on MacOS 10.10.5.

@madeinfree
Copy link
Contributor

madeinfree commented Oct 27, 2016

Hi, @udalrich with this issue remix-run/react-router#2024, npm 3 didn't auto install history now

For now I'd just recommend installing history yourself and not worrying too much about the duplicate copy. npm 3 is going to have a much flatter node_modules directory anyway, so you may not actually end up with 2 copies.

@AllenFang what do you think this issue ??

@AllenFang
Copy link
Owner

it's a known issue(#688) , I'm now writing the docs for v3.0.0. After release, I'll fix this issue

BTW, react-router is very annoying for their dependency...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants