MiscDrivers: Update all boards to use PB, LED, and stdio source files in MiscDrivers. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vers/PushButton source files.
Jacob-Scheiffler
requested review from
sihyung-maxim,
Jake-Carter and
lorne-maxim
sihyung-maxim
approved these changes
May 30, 2023
| { | ||
| MXC_GPIO_Handler(MXC_GPIO_GET_IDX(MXC_GPIO2)); | ||
| MXC_ASSERT(pb < num_pbs); |
There was a problem hiding this comment.
Instead of asserting, you can also return an error code if incorrect pb parameter, so this function can follow the doxygen comments and not have one return code.
|
@EdwinFairchild @EricB-ADI @yc-adi Not sure if any of the BLE codes use the PB library, but the BLE team should also review these changes since GPIO interrupt handling was updated. |
|
GPIO interrupt checks out |
EdwinFairchild
approved these changes
May 30, 2023
…sterCallback functions.
…MSDK/msdk into dev/migrate_led_pb_stdio
Jake-Carter
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all Include and Source directories in the Boards/ and updates all board.mk files to use MiscDrivers. Most notably this affects the LED, PB, and stdio paths/files, but some of the boards used local copies of other drivers supported in MiscDrivers and these were updated as well. As well, some minor tweaks had to be made in the LED, PB , and stdio drivers to make them compatible with all parts.