Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use commit hash instead of date in pre-release identifier (at test pypy) #103

Closed
ArneBinder opened this issue Mar 5, 2022 · 4 comments
Closed

use commit hash instead of date in pre-release identifier (at test pypy) #103

ArneBinder opened this issue Mar 5, 2022 · 4 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ArneBinder
Copy link
Owner

ArneBinder commented Mar 5, 2022 •
edited
Loading

This would ease migration tests for projects that use pytorch-ie by facilitating the alignment of a test release and the actual changes / new funcitonality.
@ArneBinder ArneBinder added the enhancement New feature or request label Mar 5, 2022
@ArneBinder ArneBinder changed the title use commit hash instead of date in pre-releases pushed to test pypy use commit hash instead of date in pre-release identifier (at test pypy) Mar 5, 2022
@ArneBinder ArneBinder mentioned this issue Mar 5, 2022
Merged
@ChristophAlt
Copy link
Collaborator

This doesn't work because it's not a valid versioning scheme. The identifier must be able to determine the release order, which is not possible with a git hash. See https://www.python.org/dev/peps/pep-0440/#dvcs-based-version-labels.
I recommend to revert the changes.

@ArneBinder
Copy link
Owner Author

ArneBinder commented Mar 6, 2022 •
edited
Loading

Ok, that's unfortunate. I will revert it, sorry for the noise.
EDIT: See #106.

@ChristophAlt
Copy link
Collaborator

No problem, I wasn't aware of that either.

@ArneBinder ArneBinder mentioned this issue Mar 6, 2022
Merged
@ArneBinder
Copy link
Owner Author

ArneBinder commented Mar 7, 2022 •
edited
Loading

I added the wontfix label, should we close this?

@ArneBinder ArneBinder added the wontfix This will not be worked on label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArneBinder @ChristophAlt