Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Regression : linter-jshint no longer works with language-babel #349

Closed
awilkins opened this issue Oct 3, 2016 · 2 comments
Closed

Regression : linter-jshint no longer works with language-babel #349

awilkins opened this issue Oct 3, 2016 · 2 comments

Comments

@awilkins
Copy link

awilkins commented Oct 3, 2016

Commit 4364381 added the source.js.jsx scope that language-babel uses - this was lost when the Coffeescript version of the linter was blown away and replaced.

I've just added 'source.js.jsx' to the list of scopes on line 38 of lib/main.js and it seems to work OK.

Is there a deeper reason for avoiding linting this scope? I understand if jshint can't cope with e.g. JSX ; in that case you could argue that the problem is with language-babel which should probably dynamically declare the right scope (ie - only add .jsx when JSX features are present).

@Arcanemagus
Copy link
Member

Closing as a duplicate of #348.

Basically I got tired of seeing bugs related to running on JSX code being reported, and JSHint itself claims no support of JSX as far as I can see. If you can find evidence that it should be working on there then we can add it back (buggy as it is). I would highly recommend moving to a linter that is actually designed to handle JSX though, such as ESLint with the proper parser + plugins.

@Arcanemagus
Copy link
Member

Actually, just re-read your message again a little more carefully. If language-babel is declaring regular JS as JSX that is definitely a bug in language-babel that should be reported there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants