Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Tools / Infinite Scroll: add support for Twenty Twenty #13511

Closed
5 of 6 tasks
jeherve opened this issue Sep 23, 2019 · 4 comments · Fixed by #13516
Closed
5 of 6 tasks

Theme Tools / Infinite Scroll: add support for Twenty Twenty #13511

jeherve opened this issue Sep 23, 2019 · 4 comments · Fixed by #13516
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Epic Formerly "Primary Issue", or "Master Issue" [Feature] Infinite Scroll [Feature] Theme Tools [Pri] High [Type] Task
Milestone

Comments

@jeherve
Copy link
Member

jeherve commented Sep 23, 2019

Twenty Twenty is expected to ship with WordPress 5.3 in November. It is currently being developed here:
https://github.com/WordPress/twentytwenty

In the past, and with previous default themes, we've added a number of compatibility files and functions to make sure new WordPress site owners had the best experience they could get when using the default theme and Jetpack. In practice, it meant adding the following:

  • Add Infinite Scroll support and tweak CSS to make sure the IS buttons look good.
  • Tweak CSS for Sharing buttons / Likes / Related Posts
  • Alter Gallery widget default width.
  • Style all Jetpack widgets to match the style of the theme.
  • Add Content Options support
  • Ensure that sharing buttons and Likes are not hooked into the excerpt when one is added to a post.

See how it was done for Twenty Nineteen for example: https://github.com/Automattic/jetpack/blob/50fe8a75fd8cfaa2aad34228ca3f02bb7ec60077/modules/theme-tools/compat/twentynineteen.php

@jeherve jeherve added this to the 7.9 milestone Sep 23, 2019
@jeherve
Copy link
Member Author

jeherve commented Sep 23, 2019

I got a PR started to start tackling those things and addressing things as I test the theme: #13516

@jeherve
Copy link
Member Author

jeherve commented Oct 25, 2019

Add Content Options support

Leaving this out for now. The theme itself comes with some basic theme options. Let's see if Content Options become needed in the future, either here or on wpcom.

@arunsathiya
Copy link

@jeherve May I ask some questions about infinite scrolling functionality on Twenty Twenty theme? I identified the following:

  • On a WordPress.org site with blog archive set to show 3 posts, and with Load more posts as the reader scrolls down enabled on Jetpack settings, I am not able to see more posts as I scroll down. I see a Older posts button in that place.
  • On the same site, with a WooCommerce product category/archive though, only a few first products appear (Not 3 unfortunately, but 12, which is a different issue) and there is no button to see more products.
Screenshot 2020-09-27 at 2 55 51 PM Screenshot 2020-09-27 at 2 55 37 PM
Screenshot 2020-09-27 at 2 55 34 PM Screenshot 2020-09-27 at 3 00 20 PM

Found when working on 3352735-zen. This information may not be sufficient for your testing, in which case, feel free to ping me for access to my test site.

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Sep 27, 2020
@jeherve
Copy link
Member Author

jeherve commented Sep 28, 2020

On a WordPress.org site with blog archive set to show 3 posts, and with Load more posts as the reader scrolls down enabled on Jetpack settings, I am not able to see more posts as I scroll down. I see a Older posts button in that place.

  • Do you happen to have footer widgets on that site?
  • What happens when you click on the "Older posts" button? Does this trigger Infinite Scroll?

On the same site, with a WooCommerce product category/archive though, only a few first products appear (Not 3 unfortunately, but 12, which is a different issue)

It may be worth trying to test with #17130 applied to your site, to see if that would solve the issue.

Let me know how that goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Epic Formerly "Primary Issue", or "Master Issue" [Feature] Infinite Scroll [Feature] Theme Tools [Pri] High [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants