Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When multiple Pay with PayPal blocks on a single page result in incorrect orders #18689

Closed
inaikem opened this issue Feb 3, 2021 · 3 comments
Labels
[Block] Pay With Paypal aka Simple Payments [Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Pay with PayPal aka Simple Payments [Type] Bug When a feature is broken and / or not performing as intended

Comments

@inaikem
Copy link
Contributor

inaikem commented Feb 3, 2021

What I expected

When multiple Pay with PayPal blocks are present on a page, I expect orders product for product A or B to result in orders/confirmations for product A or B respectively.

What happened instead

When multiple Pay with PayPal blocks are present on a page, they render correctly. However, when someone orders product A, they receive a confirmation stating they ordered product B.

The wrong item is also reflected in the (receiving account's) PayPal order history

Reported in p1612330386044400-slack-CS0SC36SX

@inaikem inaikem added [Type] Bug When a feature is broken and / or not performing as intended Pay with Paypal labels Feb 3, 2021
@inaikem inaikem changed the title When multiple Pay with PayPal blocks on a single page result in incorrect oreders When multiple Pay with PayPal blocks on a single page result in incorrect orders Feb 3, 2021
@andrewserong
Copy link
Member

Sounds like the front end of the block may not support having multiple instances on the one page? I haven't yet looked at the code, but I wonder if we can either a) restrict the number of times someone can use the block on the one page (as a short-term fix), or b) update the markup so that each block has a unique ID, and the click handler on the button should link to the correct product.

@andrewserong
Copy link
Member

Possibly a duplicate of #12801 but the reported issue sounds like there's a subtle difference, so leaving this one open, too.

@inaikem
Copy link
Contributor Author

inaikem commented Feb 4, 2021

Thanks, Andrew. The latter approach (b) to better support multiple blocks on a single page has my vote

@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" and removed Involves Happiness labels Aug 10, 2023
@jeherve jeherve closed this as completed Jan 22, 2025
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pay With Paypal aka Simple Payments [Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Pay with PayPal aka Simple Payments [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants