Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Block: Only the first form works if multiple forms have page breaks in between #41334

Closed
supernovia opened this issue Jan 27, 2025 · 6 comments · Fixed by #41407
Closed
Assignees
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@supernovia
Copy link

supernovia commented Jan 27, 2025

Impacted plugin

Jetpack

Quick summary

If a page has more than one form with page-breaks in between, only the first form works. Subsequent forms will only send (if anything) a blank copy of the first form.

Steps to reproduce

  1. Start with a Simple any site on WP.com
  2. Create a page and add two forms, preferably with different fields so the issue is more obvious, and don't make fields required
  3. Add a page-break between them, then publish and view the page
  4. Fill out and submit each form, then look at the email / feedbacks
  5. Notice the email/feedback for the second form is blank. If first form has required fields, it may not go through at all.

Editor View

Image (I had to make these not required, or it wouldn't go through at all)

Filling in the second form

Image

Feedback shows as a blank copy of the first form

Image

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

It works fine without page breaks.

Also, for now, it works fine on Atomic.

Platform (Simple and/or Atomic)

Simple

@supernovia supernovia added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 27, 2025
@supernovia
Copy link
Author

supernovia commented Jan 27, 2025

This one is an edge case, but it affects a user who has had their site set up this way for some time. They have several paginated lessons with multiple forms on them, and everything but the first forms stopped working on January 19, 2025.

9320328-zd-a8c

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9320328-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 27, 2025
@jeherve jeherve added Triaged and removed Needs triage Ticket needs to be triaged labels Jan 27, 2025
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 27, 2025
@simison
Copy link
Member

simison commented Jan 28, 2025

I was expecting #40998 to fix this, cc @Automattic/zap

Edit: nope, I read wrongly, was thinking "more" block but this is about "page break" block instead.

@supernovia supernovia changed the title Form Block: Only the first form works if multiple forms have page breaks in between (on Simple only) Form Block: Only the first form works if multiple forms have page breaks in between Jan 28, 2025
@supernovia
Copy link
Author

Update, @simison for what it's worth, this worked fine on Atomic yesterday, but today it stopped working. So I'm guessing it's a recent change.

@enejb
Copy link
Member

enejb commented Jan 29, 2025

I did an investigation here and I think the only reason why this worked is because the form was the same across the pages.
With introduction of #40998 the problem was is more predominant because the form now has different ids.

#41407 should fix this by making sure that the support is added as expected.

@edanzer
Copy link
Contributor

edanzer commented Jan 30, 2025

I think the only reason why this worked is because the form was the same across the pages

Yes, this tripped me up. I thought I couldn't duplicate. But if forms have the same fields, submissions appears to work fine. As noted in the original issue description too, you really need forms with different fields to see the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

5 participants