From d56a04c8b734f6bc59e51b11339ae36401aa9bfe Mon Sep 17 00:00:00 2001 From: Jeremy Herve Date: Fri, 22 Nov 2019 21:10:18 +0100 Subject: [PATCH 1/2] Feature Hints: disable when plugins cannot be installed on site. When one cannot install plugins, we do not have to do anything with feature hints. --- modules/plugin-search.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/plugin-search.php b/modules/plugin-search.php index aef9758094a65..7bf0ff1a396f6 100644 --- a/modules/plugin-search.php +++ b/modules/plugin-search.php @@ -1,5 +1,6 @@ Date: Fri, 22 Nov 2019 21:39:48 +0100 Subject: [PATCH 2/2] Comment new conditional See https://github.com/Automattic/jetpack/pull/14108#discussion_r349781195 --- modules/plugin-search.php | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/plugin-search.php b/modules/plugin-search.php index 7bf0ff1a396f6..9a950e0d1bdde 100644 --- a/modules/plugin-search.php +++ b/modules/plugin-search.php @@ -16,6 +16,7 @@ Jetpack::is_active() && /** This filter is documented in _inc/lib/admin-pages/class.jetpack-react-page.php */ apply_filters( 'jetpack_show_promotions', true ) && + // Disable feature hints when plugins cannot be installed. ! Constants::is_true( 'DISALLOW_FILE_MODS' ) && jetpack_is_psh_active() ) {