Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(my-account): add change email template #3772

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat(my-account): add change email template #3772

merged 3 commits into from
Feb 24, 2025

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Feb 21, 2025 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1208993180326452/1209215513701715

This PR adds a change email template:

Screenshot 2025-02-21 at 15 10 44

How to test the changes in this Pull Request:

  1. Ensure the NEWSPACK_EMAIL_CHANGE_ENABLED FF is not added in wp-config
  2. As admin, go to Newspack > Engagement > Show Advanced Settings > Transactional Email Content and confirm the Change email option is NOT present
  3. Now add the NEWSPACK_EMAIL_CHANGE_ENABLED FF in wp-config
  4. Go back to Transactional Email Content and confirm the Change email option is present
  5. Select edit and verify the editor displays content relevant for updating emails (See mockup in asana task for text)
  6. Send a test email and verify the email sends with the expected content/layout
  7. Now as a logged in reader, go to my account, enter a new email address, and save
  8. Verify the updated email template is sent

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review February 21, 2025 20:34
@chickenn00dle chickenn00dle requested a review from a team as a code owner February 21, 2025 20:34
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 21, 2025
dkoo
dkoo approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

includes/reader-revenue/my-account/class-woocommerce-my-account.php
[
self::VERIFY_EMAIL_CHANGE_PARAM => \wp_create_nonce( self::VERIFY_EMAIL_CHANGE_PARAM ),
],
\home_url()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably change in another PR when we handle the verification request, but we'll probably want to have this land on the Account Details page instead of home.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 22, 2025
@chickenn00dle chickenn00dle merged commit 32bef3c into trunk Feb 24, 2025
10 checks passed
@chickenn00dle chickenn00dle deleted the feat/add-change-email-verification-email-template branch February 24, 2025 15:28
@github-actions GitHub Actions
Copy link

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 6.0.0-alpha.2 [skip ci]
fec3c72 
# [6.0.0-alpha.2](v6.0.0-alpha.1...v6.0.0-alpha.2) (2025-02-27)

### Bug Fixes

* **memberships:** ensure user membership is linked to the correct subscription ([#3768](#3768)) ([a942616](a942616))
* undo forcing WC order attribution to off ([#3771](#3771)) ([c9cb52a](c9cb52a))
* **woo:** page template meta leaking to other types ([#3782](#3782)) ([325a21c](325a21c))

### Features

* add corrections customize settings ([#3751](#3751)) ([11dbc5e](11dbc5e))
* **corrections:** Unit tests for Corrections functionality ([#3776](#3776)) ([ae58933](ae58933))
* **my-account:** add change email template ([#3772](#3772)) ([32bef3c](32bef3c))
* **my-account:** add pending email change state ([#3763](#3763)) ([c9ba046](c9ba046))
* **my-account:** verify email change ([#3764](#3764)) ([b50c980](b50c980))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chickenn00dle @matticbot @dkoo