-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add corrections archive template #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected overall: when I add corrections to a post, they show up on the /corrections
page linked the correct posts, with the correct dates.
The only issue I spotted is when I add more than one correction to a post, one of them is duplicated -- the formatting is a little different, so I'm not sure this is intentional (like it may be to show the latest correction larger first, and then list them all underneath?).
Front end:
Post editor:
I'm marking as 'request changes', but if this is correct let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~~Looks good 👍 ~~
Oops. Seeing @laurelfulford review as I did this. I'll remove my approval in favor of her feedback!
Another review was done as I approved.
Hey @leogermani, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [2.5.0-alpha.1](v2.4.3...v2.5.0-alpha.1) (2025-02-07) ### Bug Fixes * make sure featured image behind images are centred ([#2430](#2430)) ([871838d](871838d)) ### Features * add corrections archive template ([#2431](#2431)) ([09897b0](09897b0)) * add font-loading class ([#2418](#2418)) ([24888a3](24888a3))
🎉 This PR is included in version 2.5.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
NOTE: this adds support to a feature that is still under development and behind a feature flag. It's ok that this doesn't look good yet. All we want is to be able to QA migrated data.
How to test the changes in this Pull Request:
4.Visit
yoursite.com/corrections
and confirm you see an archive for all corrections, displaying the correction date, the correction content and the title linked to the post associated with that correctionOther information: