Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add corrections archive template #2431

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

NOTE: this adds support to a feature that is still under development and behind a feature flag. It's ok that this doesn't look good yet. All we want is to be able to QA migrated data.

How to test the changes in this Pull Request:

  1. Checkout fix: update corrections post type slug newspack-plugin#3702
  2. See feat(corrections): add corrections and clarifications behind feature flag newspack-plugin#3638 for instructions on how to add the feature flag and add corrections
  3. Edit a couple of posts and add corrections using the new metabox
    4.Visit yoursite.com/corrections and confirm you see an archive for all corrections, displaying the correction date, the correction content and the title linked to the post associated with that correction

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 27, 2025
@leogermani leogermani self-assigned this Jan 27, 2025
@leogermani leogermani requested a review from a team as a code owner January 27, 2025 15:58
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected overall: when I add corrections to a post, they show up on the /corrections page linked the correct posts, with the correct dates.

The only issue I spotted is when I add more than one correction to a post, one of them is duplicated -- the formatting is a little different, so I'm not sure this is intentional (like it may be to show the latest correction larger first, and then list them all underneath?).

Front end:

CleanShot 2025-01-27 at 09 35 59

Post editor:

CleanShot 2025-01-27 at 09 37 01

I'm marking as 'request changes', but if this is correct let me know!

chickenn00dle
chickenn00dle previously approved these changes Jan 28, 2025
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Looks good 👍 ~~

Oops. Seeing @laurelfulford review as I did this. I'll remove my approval in favor of her feedback!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 28, 2025
@chickenn00dle chickenn00dle dismissed their stale review January 28, 2025 23:16

Another review was done as I approved.

@leogermani leogermani merged commit 09897b0 into trunk Feb 4, 2025
8 checks passed
Copy link

github-actions bot commented Feb 4, 2025

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 7, 2025
# [2.5.0-alpha.1](v2.4.3...v2.5.0-alpha.1) (2025-02-07)

### Bug Fixes

* make sure featured image behind images are centred ([#2430](#2430)) ([871838d](871838d))

### Features

* add corrections archive template ([#2431](#2431)) ([09897b0](09897b0))
* add font-loading class ([#2418](#2418)) ([24888a3](24888a3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 17, 2025
# [2.5.0](v2.4.3...v2.5.0) (2025-02-17)

### Bug Fixes

* make sure featured image behind images are centred ([#2430](#2430)) ([871838d](871838d))

### Features

* add corrections archive template ([#2431](#2431)) ([09897b0](09897b0))
* add font-loading class ([#2418](#2418)) ([24888a3](24888a3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants