Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block Does Not Appear Under Search Term "Image" When Adding a New Block #45136

Closed
scosgro opened this issue Aug 22, 2020 · 7 comments
Closed
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available. [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended

Comments

@scosgro
Copy link

scosgro commented Aug 22, 2020

Steps to reproduce

  1. Create a new page
  2. Click the + to add a block
  3. Search for Image
  4. The Image Block does not appear. Instead, it gives options for Gif, Image Compare, Latest Instagram Posts, Slideshow, Tiled Gallery, Story.
  5. Search for Media
  6. Image is the 5th option, Gallery the 6th.

What I expected

The Image Block to show up when you search for Image.

What happened instead

The Image Block doesn't appear when you search for "Image."

Browser / OS version

All

Screenshot / Video

image

Context / Source

#flowsharing #painpoint

@scosgro scosgro added the [Type] Bug When a feature is broken and / or not performing as intended label Aug 22, 2020
@samvaidya
Copy link

Just want to majorly +1 this. I'm seeing customers add the tiled gallery when all they wanted was one image.

@rfaile313
Copy link
Member

Same comment as above - I find it frustrating when I type /image and press enter only to create a GIF block :)

@khristiansnyder
Copy link

I ran into this today as well when searching for Video.

@scosgro
Copy link
Author

scosgro commented Aug 22, 2020

I ran into this today as well when searching for Video.

Filed: #45140

@sirreal
Copy link
Member

sirreal commented Aug 24, 2020

This is the expected behavior for Gutenberg at this time. Any proposals and changes should happen in the Gutenberg project.

Searches are sorted based on frecency. Depending on usage, you may get different results. I tested this and get these results:

Image

Screen Shot 2020-08-24 at 11 23 08

Video

Screen Shot 2020-08-24 at 11 23 19

These are exactly the results I'd expect.

This is very much dependent on a user's behavior and the inserter is behaving as expected. I do agree that the results could be better when the search term is very close to the name of a specific block. For example, blocks could be weighted by edit distance. It's a conversation that needs to happen in the core Gutenberg project.

*Note: In your screenshot there's an additional block Story (beta) that's not available in production.

[…] I find it frustrating when I type /image and press enter only to create a GIF block :)

@rfaile313 That's another issue, the Slash Inserter is different from the Quick Inserter mentioned in the description. Again, this is a conversation that needs to happen in the Gutenberg project. I find it odd that it doesn't use the same sorting as the quick inserter. The slash inserter would likely benefit from the same sort of weighting I mentioned above.

I folks would like to raise these feature requests in Gutenberg, they're welcome to, please link here. If not, @Automattic/good-mountain will create issues for the quick inserter and slash inserter in the next couple of days.

@sirreal
Copy link
Member

sirreal commented Sep 8, 2020

This should be addressed in Gutenberg 9 by WordPress/gutenberg#25105.

That change addresses these two issues which result in the behavior described here:

@david-szabo97 david-szabo97 added [Pri] Low Address when resources are available. [Status] Blocked / Hold labels Sep 9, 2020
@fullofcaffeine
Copy link
Contributor

The problem does seem to be fixed. I cleared the localstorage data for my simple test site (unsandboxed, running GB 9), and both "Image" and "Video" appears as the first item in the first row in the quick inserter (main editor or layout column).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available. [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

7 participants