Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PatchBodyParametersSchema] Property type in common-types ManagedServiceIdentity is required #751

Open
mikeharder opened this issue Oct 21, 2024 · 0 comments
Assignees

Comments

@mikeharder
Copy link
Member

mikeharder commented Oct 21, 2024

Rule PatchBodyParametersSchema generates an error if a spec uses ManagedServiceIdentity in a PATCH request:

PatchBodyParametersSchema
Properties of a PATCH request body must not be required, property:type.
RPC-Patch-V1-10

https://github.com/Azure/azure-rest-api-specs/pull/30004/checks?check_run_id=31737416686

The spec author believes their spec is correct, and suppressed the error.

Azure/azure-rest-api-specs#30004 (comment)

Is this the correct resolution? If so, should either the rule or ManagedServiceIdentity be modified to avoid this error going forward? I think all types under common-types should pass all LintDiff rules, for all intended usages by spec authors.

Related

#708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants