Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of properties to promote on a OneOf resource has been hard coded #4597

Open
theunrepentantgeek opened this issue Feb 25, 2025 · 0 comments

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

As a part of providing support for Kusto resources, we needed to hande the case where a resource is directly defined as a OneOf object.

Normal handling of OneOf types involves pushing all the properties out to the options (leaves) of the type, but this does not work for the root of a resource as we have certain required properties, starting with Name.

We now have support for this (see PR #4589), but that new stage has been hard coded to promote just the Name property.

There's no other current need to promote other one-of properties to the root - but @super_harsh suggested (correctly!) that we should create an issue to track the hard coded value - see promote_root_oneof_properties.go for all the gory details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant