Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemsAdder support (for Blueprints) #2602

Open
2 tasks done
konfix opened this issue Jan 22, 2025 · 13 comments
Open
2 tasks done

ItemsAdder support (for Blueprints) #2602

konfix opened this issue Jan 22, 2025 · 13 comments
Assignees
Labels
Status: In progress Working on the issue.

Comments

@konfix
Copy link

konfix commented Jan 22, 2025

Is your feature request related to a problem?

Hello, it would be awesome if BentoBox could support ItemsAdder custom blocks in blueprints.

This would allow users to create a blueprint that will also save all custom blocks and then load them while pasting. ItemsAdder has a documented API, and it looks like it wouldn't be too hard to implement to BentoBox's blueprints code.

From what I've been able to see, there is already a method of removing custom blocks from the island, so the only thing thing that needs to be done is actually saving the blocks and pasting them.

(I think custom blocks would be enough, there are also entities/liquids but I doubt anyone would need/want this on their islands)

The option should be toggleable somewhere in the config to prevent unnecessary performance loss, or added as a flag when saving blueprints (just like ignore air and water currently is)

It would be a very nice addition and surely that would help server owners to get more creative when creating islands :)

Example on how custom blocks can be implemented using the API:
IA-Edit - integrates IA custom blocks into FAWE (I know it's not related to blueprints but it could be useful)

Describe the solution you'd like.

/

Describe alternatives you've considered.

/

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response

@tastybento tastybento self-assigned this Jan 24, 2025
@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Jan 24, 2025
@konfix
Copy link
Author

konfix commented Feb 16, 2025

Hey, sorry, are there any news about this?

@tastybento
Copy link
Member

Not yet. I've been working on some other things. It's in the queue though.

@tastybento
Copy link
Member

Ah, I see it's a paid plugin. I'd appreciate a copy for development if you have one. It can be provided to tastybento @ bentobox.world. I only use it for development.

@konfix
Copy link
Author

konfix commented Feb 20, 2025

Ah, I see it's a paid plugin. I'd appreciate a copy for development if you have one. It can be provided to tastybento @ bentobox.world. I only use it for development.

I’ve sent you a message on Discord, since I can’t attach it in mail for some reason. Check your dms

@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 24, 2025
@tastybento
Copy link
Member

I'm added CustomBlocks to Blueprints in the latest BentoBox snapshot (ci.bentobox.world). I'll look at custom items (for chest contents) next.

@konfix
Copy link
Author

konfix commented Feb 24, 2025

Great, tysm! I'll test it and let you know if there are any issues

@konfix
Copy link
Author

konfix commented Feb 24, 2025

Great, tysm! I'll test it and let you know if there are any issues

Some blocks do work but some just appear as note blocks/tripwires, idk why that happens

@tastybento
Copy link
Member

Thanks for the feedback. Let me tweak it a bit. The real blocks may be overwriting the CustomBlocks.

@tastybento
Copy link
Member

@konfix Please try the snapshot on ci.bentobox.world when you can (it's building now).

@konfix
Copy link
Author

konfix commented Feb 24, 2025

@konfix Please try the snapshot on ci.bentobox.world when you can (it's building now).

It works now, but only visually.
If you click the note block customblock or chorus plant/tripwire, etc., it just loses its texture and turns back to vanilla state. I think the issue here is that the blocks aren't saved in IA world files as real blocks (or synced with IA in any way), therefore the actions between the player and blocks are completely unrecognized.

The blocks look normal when you create an island, but you can't interact with them the way you should.

And on my second try to regenerate the island, not even the textures show up:
Image
(there are no errors)

@tastybento
Copy link
Member

That's a bummer. For me, the normal UI doesn't work - no textures. I'm not sure if I haven't set it up right. For example, this is what I see for blocks:

Image

These are my plugins:
BentoBox (3.2.4-SNAPSHOT-LOCAL), ItemsAdder (4.0.8), LoneLibs (1.0.65), LuckPerms (5.4.153), PlaceholderAPI (2.11.6), ProtocolLib (5.4.0-SNAPSHOT-741), Vault (1.7.3-b131)

Everything I paste looks like a noteblock. I downloaded the default blocks pack but it doesn't seem to work. Not sure why.

Anyway, I changed the code to paste the baseblock before placing the IA block and maybe this'll work better. Please try the BentoBox snapshot and let me know. I'm kind of stuck testing right now. I added debug to the console on pasting, it reads correctly, but maybe there's some trick I'm missing.

Let me know.

@konfix
Copy link
Author

konfix commented Feb 25, 2025

That's a bummer. For me, the normal UI doesn't work - no textures. I'm not sure if I haven't set it up right. For example, this is what I see for blocks:

Image These are my plugins: `BentoBox (3.2.4-SNAPSHOT-LOCAL), ItemsAdder (4.0.8), LoneLibs (1.0.65), LuckPerms (5.4.153), PlaceholderAPI (2.11.6), ProtocolLib (5.4.0-SNAPSHOT-741), Vault (1.7.3-b131)`

Everything I paste looks like a noteblock. I downloaded the default blocks pack but it doesn't seem to work. Not sure why.

Anyway, I changed the code to paste the baseblock before placing the IA block and maybe this'll work better. Please try the BentoBox snapshot and let me know. I'm kind of stuck testing right now. I added debug to the console on pasting, it reads correctly, but maybe there's some trick I'm missing.

Let me know.

weird. I could provide you with a testing server on my panel and file access so you can test it there if you want. The texture pack wasn't loaded correctly for you for some reason. I'll send you a message on Discord

@tastybento
Copy link
Member

This all seems to work now, but please test it yourself and let me know.
https://ci.codemc.io/job/BentoBoxWorld/job/BentoBox/2833/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In progress Working on the issue.
Projects
None yet
Development

No branches or pull requests

2 participants