Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor lightning pay invoice route #5645

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor lightning pay invoice route #5645

wants to merge 3 commits into from
+53 −55

Conversation

lcovar
Copy link
Contributor

@lcovar lcovar commented Feb 26, 2025

No description provided.

@lcovar lcovar requested review from a team as code owners February 26, 2025 22:29
@lcovar
refactor: move passphrase to SubmitPaymentParams
fc971f9 
Move the passphrase here so we can use or codecs to check
if it's missing.

Ticket: BTC-1836

TICKET: BTC-1836
@lcovar
refactor: move lightning invoice routes to generic routes
a0f260e 
These routes should be accessible even if it's not running within
the lightning express setup.

Ticket: BTC-1836

TICKET: BTC-1836
@lcovar
chore: remove try block in lightning invoice routes
c38f836 
We should not wrap the whole thing around a try block and trow
400. It can hide legit 500 errors happening in our backend.

Ticket: BTC-1836

TICKET: BTC-1836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkaplanbitgo davidkaplanbitgo davidkaplanbitgo approved these changes

@pranavjain97 pranavjain97 Awaiting requested review from pranavjain97 pranavjain97 is a code owner automatically assigned from BitGo/wallet-platform

@kisslove-dewangan kisslove-dewangan Awaiting requested review from kisslove-dewangan kisslove-dewangan is a code owner automatically assigned from BitGo/wallet-platform

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcovar @davidkaplanbitgo