[1.2.29] Debian QA webcrawl hits fatal php error in user_admin.php

[paulgevers]

While preparing an upload for Debian with version 1.2.29, the QA pipeline fails.

This is what I see in the Apache error log:

[Sat Feb 22 20:48:50.626217 2025] [php:error] [pid 14653:tid 14653] [client ::1:49712] PHP Fatal error:  Uncaught TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given in /usr/share/cacti/site/lib/html.php:1131\nStack trace:\n#0 /usr/share/cacti/site/lib/html.php(1131): htmlspecialchars()\n#1 /usr/share/cacti/site/lib/html.php(1085): html_escape()\n#2 /usr/share/cacti/site/lib/html_form.php(790): html_create_list()\n#3 /usr/share/cacti/site/lib/html_form.php(250): form_dropdown()\n#4 /usr/share/cacti/site/lib/html_form.php(150): draw_edit_control()\n#5 /usr/share/cacti/site/user_admin.php(1878): draw_edit_form()\n#6 /usr/share/cacti/site/user_admin.php(55): user_edit()\n#7 {main}\n  thrown in /usr/share/cacti/site/lib/html.php on line 1131, referer: http://localhost/cacti/user_admin.php
[Sat Feb 22 20:48:50.659483 2025] [php:error] [pid 14655:tid 14655] [client ::1:49718] PHP Fatal error:  Uncaught TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given in /usr/share/cacti/site/lib/html.php:1131\nStack trace:\n#0 /usr/share/cacti/site/lib/html.php(1131): htmlspecialchars()\n#1 /usr/share/cacti/site/lib/html.php(1085): html_escape()\n#2 /usr/share/cacti/site/lib/html_form.php(790): html_create_list()\n#3 /usr/share/cacti/site/lib/html_form.php(250): form_dropdown()\n#4 /usr/share/cacti/site/lib/html_form.php(150): draw_edit_control()\n#5 /usr/share/cacti/site/user_admin.php(1878): draw_edit_form()\n#6 /usr/share/cacti/site/user_admin.php(55): user_edit()\n#7 {main}\n  thrown in /usr/share/cacti/site/lib/html.php on line 1131, referer: http://localhost/cacti/user_admin.php
[Sat Feb 22 20:48:50.712888 2025] [php:error] [pid 14805:tid 14805] [client ::1:49730] PHP Fatal error:  Uncaught TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given in /usr/share/cacti/site/lib/html.php:1131\nStack trace:\n#0 /usr/share/cacti/site/lib/html.php(1131): htmlspecialchars()\n#1 /usr/share/cacti/site/lib/html.php(1085): html_escape()\n#2 /usr/share/cacti/site/lib/html_form.php(790): html_create_list()\n#3 /usr/share/cacti/site/lib/html_form.php(250): form_dropdown()\n#4 /usr/share/cacti/site/lib/html_form.php(150): draw_edit_control()\n#5 /usr/share/cacti/site/user_admin.php(1878): draw_edit_form()\n#6 /usr/share/cacti/site/user_admin.php(55): user_edit()\n#7 {main}\n  thrown in /usr/share/cacti/site/lib/html.php on line 1131, referer: http://localhost/cacti/user_admin.php
[Sat Feb 22 20:48:50.949630 2025] [php:error] [pid 14657:tid 14657] [client ::1:49742] PHP Fatal error:  Uncaught TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given in /usr/share/cacti/site/lib/functions.php:68\nStack trace:\n#0 /usr/share/cacti/site/lib/functions.php(68): htmlspecialchars()\n#1 /usr/share/cacti/site/utilities.php(1178): filter_value()\n#2 /usr/share/cacti/site/utilities.php(72): utilities_view_user_log()\n#3 {main}\n  thrown in /usr/share/cacti/site/lib/functions.php on line 68, referer: http://localhost/cacti/utilities.php

[TheWitness]

@paulgevers, I texted out on out Slack Channel with the details. We had a bit of a quality spill with 1.2.29. I had hoped to get a quick turn around on 1.2.30, but I've been pretty sick that last few weeks. My post should give you enough information to fix the issues.