Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MappingSets from MappingSetModelFactory #34

Closed
ramidzkh opened this issue Jun 25, 2020 · 0 comments
Closed

Create MappingSets from MappingSetModelFactory #34

ramidzkh opened this issue Jun 25, 2020 · 0 comments

Comments

@ramidzkh
Copy link
Contributor

Lorenz basically forces all MappingSets to be an instance of MappingSetImpl as there is no way to construct a MappingSet directly from a MappingSetModelFactory
Also, there are many occurrences where MappingSet.create() is called even though a MappingSetModelFactory is available

Proposed solution:

  • Add a createMappingSet method to MappingSetModelFactory
  • Make MappingSet.create(MappingSetModelFactory) use the model factory
  • Call MappingSet.create(MappingSetModelFactory) or MappingSetModelFactory.createMappingSet() where possible (the three calls of create() in the MappingSet class don't use the existing MappingSetModelFactory)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant