You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lorenz basically forces all MappingSets to be an instance of MappingSetImpl as there is no way to construct a MappingSet directly from a MappingSetModelFactory
Also, there are many occurrences where MappingSet.create() is called even though a MappingSetModelFactory is available
Proposed solution:
Add a createMappingSet method to MappingSetModelFactory
Make MappingSet.create(MappingSetModelFactory) use the model factory
Call MappingSet.create(MappingSetModelFactory) or MappingSetModelFactory.createMappingSet() where possible (the three calls of create() in the MappingSet class don't use the existing MappingSetModelFactory)
The text was updated successfully, but these errors were encountered:
Lorenz basically forces all
MappingSet
s to be an instance ofMappingSetImpl
as there is no way to construct aMappingSet
directly from aMappingSetModelFactory
Also, there are many occurrences where
MappingSet.create()
is called even though aMappingSetModelFactory
is availableProposed solution:
createMappingSet
method to MappingSetModelFactoryMappingSet.create(MappingSetModelFactory)
use the model factoryMappingSet.create(MappingSetModelFactory)
orMappingSetModelFactory.createMappingSet()
where possible (the three calls ofcreate()
in theMappingSet
class don't use the existingMappingSetModelFactory
)The text was updated successfully, but these errors were encountered: