Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional pandas import in datatypes.string #139

Closed
Sir-MaNiAl opened this issue Mar 2, 2023 · 2 comments
Closed

Unconditional pandas import in datatypes.string #139

Sir-MaNiAl opened this issue Mar 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Sir-MaNiAl
Copy link

Sir-MaNiAl commented Mar 2, 2023

Describe the bug

There is unconditional pandas import in datatypes.string module after 7202dc5
Since pandas is an extra package and I don't install it, CH client raises exception.

clickhouse-connect logs

Traceback (most recent call last):
...
  File "/venv/lib/python3.11/site-packages/clickhouse_connect/__init__.py", line 1, in <module>
    from clickhouse_connect.driver import create_client
  File "/venv/lib/python3.11/site-packages/clickhouse_connect/driver/__init__.py", line 6, in <module>
    from clickhouse_connect.driver.client import Client
  File "/venv/lib/python3.11/site-packages/clickhouse_connect/driver/client.py", line 13, in <module>
    from clickhouse_connect.datatypes.registry import get_from_name
  File "/venv/lib/python3.11/site-packages/clickhouse_connect/datatypes/__init__.py", line 5, in <module>
    import clickhouse_connect.datatypes.string
  File "/venv/lib/python3.11/site-packages/clickhouse_connect/datatypes/string.py", line 3, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'
@Sir-MaNiAl Sir-MaNiAl added the bug Something isn't working label Mar 2, 2023
@genzgd
Copy link
Collaborator

genzgd commented Mar 2, 2023

Ack, sorry about that. Fix should be released shortly.

@genzgd
Copy link
Collaborator

genzgd commented Mar 2, 2023

0.5.14 released with a fix.

@genzgd genzgd closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants