Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Share icons point to the Custom Layout instead of the actual post #1270

Closed
Tracked by #1271
JohnPixle opened this issue Oct 17, 2022 · 1 comment · Fixed by #1430
Closed
Tracked by #1271

Social Share icons point to the Custom Layout instead of the actual post #1270

JohnPixle opened this issue Oct 17, 2022 · 1 comment · Fixed by #1430
Assignees
@arinaturcu
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Custom layouts Issues related to the compatibility between Otter and Neve custom layouts released Indicate that an issue has been resolved and released in a particular version of the product.
Milestone
2.2.2

Comments

@JohnPixle
Copy link
Contributor

When used in the context of a CL template, the social share icons will actually share the Custom Layout template, and not the actual post.

To replicate this, just share this post from the social share icons at the bottom.

Screenshot 2022-10-17 at 19 42 40

this is from the twitter share popup:

Screenshot 2022-10-17 at 19 42 04
@JohnPixle JohnPixle added the Custom layouts Issues related to the compatibility between Otter and Neve custom layouts label Oct 17, 2022
@JohnPixle JohnPixle mentioned this issue Oct 17, 2022
Closed
5 tasks
@HardeepAsrani HardeepAsrani added the bug This label could be used to identify issues that are caused by a defect in the product. label Oct 18, 2022
@arinaturcu arinaturcu mentioned this issue Jan 6, 2023
Merged
7 tasks
@arinaturcu arinaturcu linked a pull request Jan 6, 2023 that will close this issue
fix: sharing icons link to wrong post when used in neve custom layouts #1430
Merged
7 tasks
@HardeepAsrani HardeepAsrani added this to the 2.2.1 milestone Jan 12, 2023
@HardeepAsrani HardeepAsrani modified the milestones: 2.2.1, 2.2.2 Jan 30, 2023
@HardeepAsrani HardeepAsrani mentioned this issue Jan 30, 2023
Merged
7 tasks
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arinaturcu arinaturcu

Labels
bug This label could be used to identify issues that are caused by a defect in the product. Custom layouts Issues related to the compatibility between Otter and Neve custom layouts released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
2.2.2
Development

Successfully merging a pull request may close this issue.

fix: sharing icons link to wrong post when used in neve custom layouts Codeinwp/otter-blocks
4 participants
@HardeepAsrani @JohnPixle @arinaturcu @pirate-bot