Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exhaustive checks for errors in contracts #105

Closed
maurolacy opened this issue Oct 4, 2020 · 3 comments
Closed

Add exhaustive checks for errors in contracts #105

maurolacy opened this issue Oct 4, 2020 · 3 comments

Comments

@maurolacy
Copy link
Contributor

Some contracts (like subkeys) have error conditions / cases that are not being triggered / checked in unit tests. Let's add those for completeness.

@ethanfrey
Copy link
Member

This is too vague.
Can you please give some concrete examples so we can make PRs to fix them (can be new issues per contract, or adding a checklist to this issue). If they have been since fixed, let's close this.

@maurolacy
Copy link
Contributor Author

This was useful as an initial task for @hashedone to get used to the framework.

I would say, let's close this, and in any case create specific issues to improve testing, and the test framework / techniques.

@maurolacy
Copy link
Contributor Author

Closing as too vague / general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants