Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip CI jobs for draft PRs #1425

Open
lenaploetzke opened this issue Feb 20, 2025 · 2 comments · May be fixed by #1429
Open

Skip CI jobs for draft PRs #1425

lenaploetzke opened this issue Feb 20, 2025 · 2 comments · May be fixed by #1429
Assignees
@Davknapp
Labels
CI Continuous Integration

Comments

@lenaploetzke
Copy link
Collaborator

Feature request

We agreed to create draft PRs early in order to get early feedback and promote exchange with the other developers. However, the CI is currently triggered with every commit in draft PRs. It is not possible not to trigger the CI for Draft PRs at all, but we could skip the majority of the jobs (see also https://github.com/orgs/community/discussions/102838).
We just have to add if: github.event.pull_request.draft == false to the jobs that should not run in the case of draft PRs.

Is your feature request related to a problem? Please describe.
The CI runs for every commit in draft PRs

Describe alternatives you've considered
Use [ci skip] in draft PRs more frequently.

Estimated priority
"Priority: medium" Should be solved within half a year
@lenaploetzke lenaploetzke added the CI Continuous Integration label Feb 20, 2025
@sandro-elsweijer
Copy link
Collaborator

sandro-elsweijer commented Feb 24, 2025 •
edited
Loading

  • We discussed that the CMake CI should be skipped in draft PRs unless the commit message indicates otherwise (like including a [run ci]). This can easily be achieved via @lenaploetzke's proposed solution and the addition of the parsing of the commit message for s specific substring.
  • The spell and indentation check should run as usual.
  • The tarball test should only be run in the nightly and the merge queue.
  • The tests in the merge queue should run the full test suite (without less tests)
  • Then all tests (including spell and indent) after a merge into main can be deactivated because they ran already in the merge queue.

@Davknapp Davknapp self-assigned this Feb 25, 2025
@Davknapp Davknapp linked a pull request Feb 25, 2025 that will close this issue
Open
20 tasks
@Davknapp
Copy link
Collaborator

Davknapp commented Feb 25, 2025 •
edited
Loading

  • The tarball test should only be run in the nightly and the merge queue.

This is probably not possible in the current setup.
A merge queue runs on top of the branch protection. There is not a seperate rule-set for the merge queue.
If we want to ensure that the tarball can be constructed properly we should put this test in our branch protection (and I think it is a good idea). But this means that it has to run on every PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Davknapp Davknapp

Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CI to a more finegrained CI DLR-AMR/t8code
3 participants
@Davknapp @sandro-elsweijer @lenaploetzke