-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: UrlQueryInfo and ExtUrlQueryInfo support #4578
Feature: UrlQueryInfo and ExtUrlQueryInfo support #4578
Conversation
feature: urlQueryString first version returning initialQueryString params
@JoaquinBCh : Thanks for the PR i added my review. In addition:
|
One more thing: Please add the sample page you implemented to the sample section in the |
…o feature/UrlQueryInfo
Implement url query info review suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comments:
- For UseMPDUrlQuery and QueryString the resulting query args include invalid values. Example: https://comcast-dash-6-assets.s3.us-east-2.amazonaws.com/ExtUrlQueryInfo/case4.mpd?token=righttoken&other=true . From my understanding the
other=true
parameter shall not be included as we are only selecting thetoken
parameter:queryTemplate="token=$query:token$
. Example output URL:
https://cloudfront.content-steering.com/bbb/video_1920x1080_4531kbps/seg-12.m4f?battery=80&token=righttoken&other=tru. Please verify and also add a unit test if this is a bug. - The reference content still uses
urn:mpeg:dash:urlparam:2014
forup:ExtUrlQueryInfo
instead ofurn:mpeg:dash:urlparam:2016
- Edit: Please also merge the latest changes from the development branch
Discussion in the dash.js call on 15th October: The logic for supporting templates with |
fdf3308
into
Dash-Industry-Forum:development
This PR implements UrlQueryInfo and ExtUrlQueryInfo
Summary
includeInRequest
supported:segment
,mpd
,mpdpatch
andsteering
Assumptions
mpd
andmpdpatch
when deciding whether to return a query string or not; both types of requests are treated the same.Testing
Manifests with different UrlQuery configurations for testing:
includeInRequest
configured to steering.A sample page has been created to test all the listed manifests and view the requests made by the player. You can access it here:
Sample Page for URL Query Info Testing