More kubelet tests

DataDog · Feb 26, 2025 · 6ed7532 · 6ed7532
1 parent 407ff22
commit 6ed7532
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/comp/core/workloadmeta/collectors/internal/kubelet/kubelet_test.go b/comp/core/workloadmeta/collectors/internal/kubelet/kubelet_test.go
@@ -65,6 +65,17 @@ func TestPodParser(t *testing.T) {
 								"cpu": resource.MustParse("100m"),
 							},
 						},
+						Env: []kubelet.EnvVar{
+							{
+								Name:  "ExplicitEnvVar",
+								Value: "true",
+							},
+							{
+								Name:      "ImplicitEnvVar",
+								Value:     "",
+								ValueFrom: &struct{}{},
+							},
+						},
 					},
 				},
 			},
@@ -121,8 +132,10 @@ func TestPodParser(t *testing.T) {
 			Kind: "kubernetes_pod",
 			ID:   "uniqueIdentifier",
 		},
-		Ports:   []workloadmeta.ContainerPort{},
-		EnvVars: map[string]string{},
+		Ports: []workloadmeta.ContainerPort{},
+		EnvVars: map[string]string{
+			"ExplicitEnvVar": "true",
+		},
 		State: workloadmeta.ContainerState{
 			Health: "healthy",
 		},

diff --git a/pkg/util/kubernetes/kubelet/kubelet_test.go b/pkg/util/kubernetes/kubelet/kubelet_test.go
@@ -883,7 +883,10 @@ func (suite *KubeletTestSuite) TestContainerEnvVars() {
 	require.NotNil(suite.T(), nginxContainer)
 
 	expectedEnvVars := []EnvVar{
+		// Variable explicitly defined in the pod spec
 		{Name: "DEFINED_VAR", Value: "true"},
+		// Variable from an external source (eg. ConfigMap, Secret, Downward API, etc.)
+		{Name: "UNDEFINED_VAR", Value: "", ValueFrom: &struct{}{}},
 	}
 	assert.ElementsMatch(suite.T(), nginxContainer.Env, expectedEnvVars)
 }